Add height:auto to video in Video block
#37052
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +21 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
|
Perhaps we could do something similar to what we did in the twentytwentyone theme? |
|
But relying on a script to obtain the width/height on the frontend is not optimal for performance, right? That will result in layout shift when the script runs. I thought the point of browsers implementing a default The AMP plugin is obtaining the In any case, I'm seeing some strange browser behavior for |
|
I think we could combine the 2... A PHP implementation makes more sense than a JS one as it will be more performant and will avoid layout shifts like you said. |
7 tasks
|
My understanding is that only setting the |
|
The reason I'm a bit hesitant with using |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This amends #30092 which added
height:autoto somevideoelements but didn't include the video in the Video block.Description
In the AMP plugin we add
widthandheightattributes to videos in order to prevent layout shifts, which are currently a reality with videos in the Video block since no dimensions are provided as they are forimgelements:video-layout-shift.mov
However, at the moment adding the
widthandheightis currently causing the video to be stretched. By addingheight:auto, the stretching is eliminated.height:autoheight:autoHow has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).