Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Templates Controller: Add missing 'is_custom' prop #36911

Merged
merged 2 commits into from
Nov 26, 2021
Merged

Templates Controller: Add missing 'is_custom' prop #36911

merged 2 commits into from
Nov 26, 2021

Conversation

Mamaduka
Copy link
Member

Description

The prop was originally introduced in #35802. It returns a boolean value whether a template is a custom template and isn't part of WP default templates.

How has this been tested?

Unit tests should pass.

Types of changes

Bugfix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@Mamaduka Mamaduka requested a review from youknowriad November 26, 2021 12:22
@Mamaduka Mamaduka self-assigned this Nov 26, 2021
@Mamaduka Mamaduka added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta Core REST API Task Task for Core REST API efforts labels Nov 26, 2021
ntsekouras
ntsekouras approved these changes Nov 26, 2021
View reviewed changes
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Mamaduka
Copy link
Member Author

Thanks, Nik. I'm going to create a core patch on Monday.

@Mamaduka Mamaduka merged commit 6466208 into trunk Nov 26, 2021
@Mamaduka Mamaduka deleted the fix/template-controller-missing-prop branch November 26, 2021 16:17
@github-actions github-actions bot added this to the Gutenberg 12.1 milestone Nov 26, 2021
@Mamaduka Mamaduka mentioned this pull request Nov 28, 2021
Merged
7 tasks
@noisysocks noisysocks removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Nov 29, 2021
noisysocks pushed a commit that referenced this pull request Nov 29, 2021
@Mamaduka @noisysocks
Templates Controller: Add missing 'is_custom' prop (#36911)
ef7edf3 
* Templates Controller: Add missing 'is_custom' prop

* Add prop only for wp_template
@noisysocks noisysocks mentioned this pull request Nov 29, 2021
Closed
@afercia afercia mentioned this pull request Feb 9, 2023
Closed
@oandregal oandregal mentioned this pull request Jun 3, 2024
Closed
1 task
@Aljullu Aljullu mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@Mamaduka Mamaduka

Labels
Core REST API Task Task for Core REST API efforts [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 12.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Mamaduka @ntsekouras @noisysocks