Use table layout in templates list screen #36707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Focus] Accessibility (a11y)
|
Size Change: +22 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
|
I checked this out and confirmed it still all looks reasonable:
When I turned VoiceOver on, however, for some reason it keeps announcing the table as "1 column, 2 rows" even though there are 3 columns and 9 rows. It works properly when I e.g. browse to |
|
It's showing 3 columns and 7 rows for me though 🤔 . |
Similar here when testing in Safari, though "1 column, 0 rows". 😬 Also couldn't navigate the table in Safari using Ctrl+Option+Arrow Key. Maybe there's some setting that I'm missing. I also tested Voiceover in Brave, and there it correctly announces the table size (3 columns, 11 rows), and Ctrl+Option+Arrow Key navigation works. |
|
I think it's because
|
38 tasks
talldan
approved these changes
Nov 22, 2021
|
There are some style regressions here. If possible, it would be good to hold off on merging PRs that affect UI until there has been a design review. |
|
@jameskoster Sorry about that! I thought I made the style backward-compatible 🙈 . If you could point out the regressions in #36597 I'll fix them in another PR! |
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 29, 2021
* Use table layout * Add explicit aria roles * Add comments
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #36702.
Use
<table>layout in templates list page to follow accessibility best practices.How has this been tested?
tt1-blockstheme<table>tag and it should have implicit aria roles (Chrome devtools -> Elements -> Accessibility)Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).