Try: Hide the in-canvas appender in the site editor. #36602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
[Feature] Inserter
jasmussen
requested review from
shaunandrews,
mtias,
jameskoster and
apeatling
|
Size Change: +30 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
This was referenced Nov 18, 2021
|
Closing in favor of #36605. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alternative to #36037. Entirely removes/hides the in-canvas inserter — the little black plus that appears when you select a nesting container — when you're using the site editor.
The layout shifts that this element is causing are very disruptive to the site editing flow, enough that a temporary measure such as this might be worth employing.
The measure is meant to be temporary until such a time as we can find a better replacement that works for both editors. See also #26404.
How has this been tested?
Verify that the black plus button appears in the post editor, when seleting a nesting container:
Verify that it doesn't appear in the site editor.
Checklist:
*.native.jsfiles for terms that need renaming or removal).