Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove textdomain from calendar block #36500

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

kebbet
Copy link
Contributor

@kebbet kebbet commented Nov 15, 2021

Description

Gutenberg text domain was introduced in core, this PR removes that text domain.
Closes: #36499
Core ticket: https://core.trac.wordpress.org/ticket/54444#comment:4

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @kebbet! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 15, 2021
@Mamaduka Mamaduka added [Block] Calendar Affects the Calendar Block [Type] Bug An existing feature does not function as intended Internationalization (i18n) Issues or PRs related to internationalization efforts and removed [Type] Bug An existing feature does not function as intended labels Nov 16, 2021
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. Thanks for contributing, @kebbet.

@Mamaduka Mamaduka added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Nov 16, 2021
@Mamaduka Mamaduka merged commit 0af8495 into WordPress:trunk Nov 16, 2021
@github-actions github-actions bot added this to the Gutenberg 12.0 milestone Nov 16, 2021
@kebbet
Copy link
Contributor Author

kebbet commented Nov 19, 2021

Thanks for accepting. Will this change be back-ported to WordPress 5.9? @Mamaduka

@Mamaduka
Copy link
Member

Yes, it will be back-ported.

@noisysocks noisysocks removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Calendar Affects the Calendar Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove gutenberg textdomain in calendar-block from @wordpress package
3 participants