Update resize handle styling in template part focus mode #36410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
Needs Design Feedback
|
Size Change: +113 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
|
I think it's ok if they look a bit like scrollbars, perhaps even thinner. The icon can be actually confused with movers, no? |
|
Seems ok if they look a bit like scrollbars, but at the moment...
Thinner and closer to the canvas might be adequate:
The color still makes me twitch a bit though. One step further would be to apply an outline, or even make it more handley:
|
|
Nice! The clearer color could work if it doesn't steal too much attention in the context of the whole interface. |
This reverts commit bd6fa21.
|
Pushed a different approach. The color is tricky, I lightened it by one notch so it differs from scrollbars. I don't think it interferes with focus too much.
|
|
Do you think the handles are too long/tall if we compare them with the segmented component in inspector, or are you considering larger parts and/or have sufficient clickable area? |
Sorry, I'm unsure what you're referring to there. |
|
Apologies, I was referring to the relationship between these two linear elements:
|
|
Ah, the highlight style on the active tab? It may be tricky to establish any kind of relationship there since the tab can be different lengths based on the locale. It doesn't feel quite so important because oftentimes the inspector will be hidden anyway. There may be some value in making the handle a height relative to the canvas, though 🤔 |
|
Any objections to merging this one? Here's the before/after: Beforebefore.mp4After (this PR)after.mp4 |
jameskoster
assigned jasmussen and pablohoneyhoney and unassigned jasmussen and pablohoneyhoney
|
Looks good, land it! We can always tweak further if we need to. |
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having worked in template part focus mode for some time, I have occasionally been tricked in to thinking the resize handle is a scrollbar. This PR explores some changes we could make to address that.
I also updated the cursor to
ew-resizewhich seems more appropriate.We may only need one or two of the changes above. But by adding them all initially we can refine from here.