Add _wp_array_set and _wp_to_kebab_case to 5.8 compat
#36399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `gutenberg_experimental_set` with `_wp_array_set` and `gutenberg_experimental_to_kebab_case` with `_wp_to_kebab_case`. These functions was added in WordPress 5.8. This fixes a issue with the page list block where `gutenberg_experimental_to_kebab_case` is used. WordPress doesn't have this function and the block will fail when used.
walbo
requested review from
oandregal,
spacedmonkey,
tellthemachines and
TimothyBJacobs
as code owners
noisysocks
pushed a commit
that referenced
this pull request
Nov 23, 2021
Replace `gutenberg_experimental_set` with `_wp_array_set` and `gutenberg_experimental_to_kebab_case` with `_wp_to_kebab_case`. These functions was added in WordPress 5.8. This fixes a issue with the page list block where `gutenberg_experimental_to_kebab_case` is used. WordPress doesn't have this function and the block will fail when used.
bph
added
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace
gutenberg_experimental_setwith_wp_array_setandgutenberg_experimental_to_kebab_casewith_wp_to_kebab_case.These functions was added in WordPress 5.8.
This fixes a issue with the page list block where
gutenberg_experimental_to_kebab_caseis used. WordPress doesn't have this function and the block will fail when used in 5.9.Types of changes
gutenberg_experimental_setwith_wp_array_setandgutenberg_experimental_to_kebab_casewith_wp_to_kebab_case