Fix submenus not opening on click #36290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Block] Navigation
tellthemachines
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: 0 B Total Size: 1.08 MB ℹ️ View Unchanged
|
vcanales
approved these changes
Nov 8, 2021
|
Cherry-picked into the GB 11.9 release in e7e5305 |
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Open on click functionality in Navigation Submenus is broken. A bit of poking around showed the event listener wasn't being added to the buttons, probably because the script is being loaded before the markup is present on the page.
This PR changes the script to only add the event listeners after the DOM is fully loaded.
How has this been tested?
Add a Navigation block with a few menu items and Submenus. Set it to open on click.
Save and visit the page on the front end. Check that submenus open on click, and close on click or focus outside.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).