Chore: Add comment to Remove filter to allow WP variables after min version is 5.8. #36281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
Global Styles
jorgefilipecosta
requested review from
oandregal and
spacedmonkey
as code owners
|
The plugin still supports WP 5.7. Maybe we should add the note to remove the filter once Gutenberg requires 5.8? |
jorgefilipecosta
force-pushed
the
remove/unnecessary-filter-to-allow-wp-variables
branch
from
f0efc87 to
6a128ae
Compare
|
Hi @Mamaduka, good catch. I updated the PR just to contain a note, it makes things easier as with that we know we don't need to backport to the core. |
jorgefilipecosta
changed the title
jorgefilipecosta
deleted the
remove/unnecessary-filter-to-allow-wp-variables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Gutenberg, we had a filter to allow wp variables to be used on a specific set of CSS properties. This filter is not needed anymore since WordPress 5.8 started to allow any CSS variable in any property WordPress/wordpress-develop@8e498a8314.