Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Library: Add alignment option to the Comment Edit Link block #36033

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Block Library: Add alignment option to the Comment Edit Link block #36033

merged 2 commits into from
Oct 28, 2021

Conversation

cbravobernal
Copy link
Contributor

@cbravobernal cbravobernal commented Oct 28, 2021 •
edited
Loading

Description

With this PR, we add alignment options to the Post Comment Edit Link Block.
Closes https://github.com/WordPress/gutenberg/projects/61#card-71691451

How has this been tested?

  • Created Post Comment Edit block.
  • Added Edit Link Block.
  • Assigned different options for text-align.
  • Check both editor and frontend.

Screenshots

Loom: https://www.loom.com/share/96228fbd1e3a4134bf8b3ccbf8e442fe

Screenshot 2021-10-28 at 12 29 14

Types of changes

A small new feature with no breaking changes.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.

gziolo
gziolo approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and quick follow-up, thank you for working on it 👍🏻

@gziolo gziolo merged commit 6419aff into WordPress:trunk Oct 28, 2021
@gziolo gziolo added [Type] Enhancement A suggestion for improvement. [Block] Comment Template Affects the Comment Template Block labels Oct 28, 2021
@github-actions github-actions bot added this to the Gutenberg 11.9 milestone Oct 28, 2021
@gziolo gziolo changed the title Update / Add alignment option to post comment edit block Block Library: Add alignment option to the Comment Edit Link block Oct 28, 2021
@cbravobernal cbravobernal deleted the update/add-text-align-control-comment-edit-link branch October 28, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Block] Comment Template Affects the Comment Template Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 11.9
Development

Successfully merging this pull request may close these issues.
2 participants
@cbravobernal @gziolo