Auto resize the height of template part focus mode #35974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Feature] Template Editing Mode
kevin940726
force-pushed
the
add/auto-resize-template-part-focus-mode
branch
from
1e0b220 to
742ceca
Compare
|
Size Change: +63 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
I think this is the one.
In the future it would be nice to display the pixel value somewhere on the canvas, and maybe have the width snap to popular device widths, just to doubly illustrate that this is resizing the preview, not the template part itself. But we can do that in a follow-up.
This was referenced Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #35512. Alternative to #35943 and #35856. Implement the design similar to the one in #35512 (comment).
Auto-resize the height of the template part focus mode with
ResizeObserver. Also removed the preview options in the focus mode until we implement the "viewport width" options instead.How has this been tested?
tt1-blocksthemeScreenshots
Kapture.2021-10-27.at.10.36.16.mp4
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).