Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile - Add support for the Mark HTML tag and updates Aztec iOS to 1.19.5 #35956

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

geriux
Copy link
Member

@geriux geriux commented Oct 26, 2021

Description

Updates Aztec iOS to 1.19.5, with this and with the recently released Aztec Android, it adds support for the mark HTML tag.

How has this been tested?

  • Open the app with metro running
  • Toggle to HTML mode
  • Paste the following snippet:
<!-- wp:paragraph -->
<p>Hey <mark style="background-color:#f0c25d;color:#ff0000" class="has-inline-color">there!</mark> this is a test.</p>
<!-- /wp:paragraph -->
  • Toggle back to Visual mode
  • Expect to see the text: Hey there! this is a test in the editor. It's expected to see the text color (not the background), and the customization for this new format is under development on mobile.

Screenshots

Before iOS After iOS
Before Android After Android

Types of changes

New feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@geriux geriux added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Oct 26, 2021
Copy link
Member

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for wrangling this @geriux 🙇
Everything looks good and works as expected 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants