Add a method to disable auto-accepting dialogs #35828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Tool] E2E Test Utils
|
Size Change: +112 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Oct 21, 2021
Co-authored-by: Dave Smith <getdavemail@gmail.com>
fullofcaffeine
added a commit
that referenced
this pull request
Oct 21, 2021
* trunk: (494 commits) remove consecutive rc warning (#35855) Update Changelog for 11.8.0-rc.2 Bump plugin version to 11.8.0-rc.2 [RNMobile] Disable React Native E2E Tests (iOS) (#35844) Add section about using the schema during development (#35835) Add a method to disable auto-accepting dialogs (#35828) Wrap NavigationContainer with SafeAreaView. (#35570) Update Appium to 1.22.0 (#35829) Post Comment: Handle the case where a comment does not exist (#35810) Clear selected block when clicking on the gray background (#35816) Post excerpt: Don't print the wrapper when there is no excerpt (#35749) [Block] Navigation: Fix padding for social links on mobile (#35824) Fix issue with responsive navigation causing wrapping. (#35820) [Block Editor]: Fix displaying only `none` alignment option (#35822) Add API to access global settings, styles, and stylesheet (#34843) Mobile Release v1.64.1 (#35804) Add resizer to template part focus mode (#35728) Update Changelog for 11.7.1 Gallery block: Only show the gallery upload error message if mixed multiple files uploaded (#35790) Update Changelog for 11.8.0-rc.1 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
enablePageDialogAcceptis enabled insetup-test-frameworkwhich auto-accepts all dialogs on the page. I think this is overly aggressive and there's currently no way to disable it either.This had been brought up in WordPress/wordpress-develop#1746 (comment), which at first was very confusing why the dialog kept closing automatically. I believe this method was originally introduced to automatically accept only the "Are you sure you want to leave before saving" dialogs, maybe we should target that individually instead of aggressively closing all dialogs?
Either way, I think it makes sense to still provide a method to disable this functionality. Hence, this PR adds a new API
disablePageDialogAcceptwhich will do exactly that.How has this been tested?
Create a new test somewhere with the following content and run it.
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).