Typography Panel: Update typography controls for display in ToolsPanel #35451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the redundant font size picker when used within the ToolsPanel. It also tweaks the styles to lay out the component nicely and leave the spacing to the ToolsPanel grid layout.
Renamed to improve clarity of purpose. Also added to README.
aaronrobertshaw
added
[Feature] UI Components
aaronrobertshaw
requested review from
ajitbohra,
chrisvanpatten and
ellatrix
as code owners
This was referenced Oct 8, 2021
|
Size Change: +99 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
Thank you for opening this PR to tackle these styling issue separately from other work! While I haven't had the time yet to look into this (I will try to do so between before Monday EOD), I just wanted to flag that @ntsekouras has also been working on the |
|
Thanks @ciampo. Apologies for the slow reply, I've been AFK the last few days. There was some discussion that we may wish to land the PR switching the Typography Panel to a The latest info I have is that the new controls may only be a few days away from being merged. I'm happy to close this PR and wait for the new controls. At that point, I'll update #33744 again and can create new issues for any issues uncovered at that point. |
Sounds like a good plan to me, thank you so much for your flexibility in coordinating with parallel work happening on those components! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Related:
Description
This PR includes:
showResetButtonprop for the existingFontSizePickerwhich allows it to be hidden when made redundant by the control's inclusion within aToolsPanelFontSizePickerso the predefined and custom fields take up available space and line up neatlyToolsPanelgrid layout.Important
If the new typography controls land before the Typography switch to the
ToolsPanel, this PR is not required.How has this been tested?
Manually.
ToolsPanelScreenshots
Types of changes
New Feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).