Components: withAPIData: Don't restrict to /wp/v2, allow custom endpoints #3536
Conversation
mcsf
added
the
Framework
| wp_json_encode( $schema_response->get_data() ) | ||
| wp_json_encode( array( | ||
| 'namespace' => '', | ||
| 'routes' => $schema_response->get_data()[ 'routes' ], |
There was a problem hiding this comment.
Per failing test:
Function array dereferencing is not present in PHP version 5.3 or earlier (PHPCompatibility.PHP.NewFunctionArrayDereferencing.Found)
Further, why do we need to do this change at all? Can we not just encode the data as we had done previously?
There was a problem hiding this comment.
We can, but the data has a different shape. Instead of getting an object with keys ( namespace, routes ), we have keys ( name, description, url, home, gmt_offset, timezone_string, namespaces, authentication, routes, permalink_structure ). Note the plural namespaces. Hence the sort-of-faking happening here. How do you suggest proceeding? We can indeed pass the entire data and handle it differently on the client.
There was a problem hiding this comment.
As far as I can recall, withAPIData really only cares about the routes property, and if we assume the schema response' routes includes all registered routes, all the better. Other keys can simply be ignored.
There was a problem hiding this comment.
I've tested this change both as-is and by reverting the encoding changes as per some discussion with @aduth . Works great!
I can submit a separate PR, but thought it might be easier for someone with commit access to make the change in this PR and put the encoding stuff back in. Cheers!
Never mind. I really need this so I've created PR #3778. Thx.
|
Related: #3462 |
|
Superseded by #3778 |
Description
Fixes #3209
How Has This Been Tested?
/sensei/v1/coursesis found alongside the request to/wp/v2/course-category.withAPIDatawithin the framework (e.g. sidebar controls)./cc @donnapep
Types of changes
Checklist: