Remove shift-stepping from range in RangeControl #35020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: -85 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
This was referenced Sep 21, 2021
stokesman
force-pushed
the
fix/range-control-shift-tab-reset-with-fire
branch
from
20d18b4 to
efdce4e
Compare
ciampo
reviewed
Sep 22, 2021
There was a problem hiding this comment.
From a quick test (both in Storybook and in the Columns slider, as described in #34363), this seems to work as expected.
TODO: test it better.
Let me know when you're satisfied with the level of testing (did you mean to add more unit tests?).
Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
|
Thanks for the help @ciampo.
I'm satisfied. I'd simply wanted to give myself time in case it would occur to me there's some odd edge case to test and that hasn't happened. |
ciampo
added
[Feature] UI Components
ciampo
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
Let's merge this!
(Technically a breaking change. Though after discussion in #34719, no one raised concerns that it would break code.)
Let's keep an eye out for potential bug reports about this, and be ready to revert this PR in case.
4 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #34719 to fix #34363. Removes the application of
shiftStepto the changes from theinput [type=range]inRangeControl.I threw in a smidgen of cleanup of some props in the range sub-component. I was tempted to remove the whole thing as it doesn't do much besides add boilerplate at this point.
How has this been tested?
Verifying that the bug from #34363 can no longer be reproduced as well as less specific instances of it.
Verifying that the NumberControl still shift-steps as expected.
Types of changes
Bug fix
(Technically a breaking change. Though after discussion in #34719, no one raised concerns that it would break code.)
Checklist:
*.native.jsfiles for terms that need renaming or removal).