Update the Global Styles Icon and use in the site editor's panel #34871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
Global Styles
jasmussen
approved these changes
Sep 16, 2021
|
Size Change: -306 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
mtias
reviewed
Sep 20, 2021
| @@ -81,6 +81,7 @@ export { default as formatUnderline } from './library/format-underline'; | |||
| export { default as formatUppercase } from './library/format-uppercase'; | |||
| export { default as fullscreen } from './library/fullscreen'; | |||
| export { default as gallery } from './library/gallery'; | |||
| export { default as globalStyles } from './library/global-styles'; | |||
There was a problem hiding this comment.
Wonder if we should be calling this one just styles
There was a problem hiding this comment.
I've no strong opinion. I case we want to do it, here's a PR. The argument for calling it "global styles" was that it feels like a branded symbol that should not be used for any other interface.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20873
Here's how it looks like