Navigation Screen: Consolidate menu name and switcher #34786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Navigation Screen
[Type] Enhancement
Mamaduka
force-pushed
the
try/nav-screen-header-actions
branch
from
2b58ff5 to
efd3784
Compare
|
Size Change: +307 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
Mamaduka
requested review from
adamziel,
ajitbohra,
draganescu,
getdave,
kevin940726,
nerrad,
ntwb,
talldan and
tellthemachines
as code owners
|
a11y question: Should we display visually hidden "Editing: {menu.name}" text near the visible menu name? |
Mamaduka
force-pushed
the
try/nav-screen-header-actions
branch
from
efd3784 to
16e81a6
Compare
javierarce
approved these changes
Sep 14, 2021
|
Thanks, @javierarce. There's already an issue for long menu names - #34512. |
getdave
approved these changes
Sep 14, 2021
|
Thanks for the reviews, @javierarce, and @getdave ❤️ |
fullofcaffeine
added a commit
that referenced
this pull request
Sep 16, 2021
* trunk: (74 commits) Update docs for ClipboardButton component (#34711) Post Title Block: add typography formatting options (#31623) Bump plugin version to 11.5.0 Navigation Screen: Adjust header toolbar icon styles (#34833) Fix the parent menu item field in REST API responses (#34835) Rewrite FocusableIframe as hook API (#26753) Create Block: Remove wp-cli callout since not recommended and outdated (#34821) Global Styles: Fix dimensions panel default controls display (#34828) [RNMobile][Embed block] Enable embed preview for Instagram and Vimeo providers (#34563) Increase Link UI search results to 10 on Nav Editor screen (#34808) Prevent welcome guide overflow x scroll (#34713) Enable open on click for Page List inside Navigation. (#34675) [RNMobile] [Embed block] - Unavailable preview fallback bottom sheet title update (#34674) Add missing field _invalid in menu item REST API (#34670) Fix Dropdown/DropdownMenu toggle closing in all UAs (#31170) Navigation submenu block: replace global shortcut event handlers with local ones (#34812) Navigation Screen: Consolidate menu name and switcher (#34786) Remove parent and position validation from menu item REST API endpoint (#34672) Clean theme data when switching themes in the customizer (#34540) Components: add reset timeout to ColorPicker's copy functionality. (#34601) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #31241.
PR combines the menu name and switcher into a single component. It also introduces a new top-level "New menu" button.
P.S. Header menu actions will center on small screens once #34619 is merged.
How has this been tested?
The e2e tests are passing.
Screenshots
CleanShot.2021-09-14.at.14.26.22.mp4
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).