Border Support: Fix check for displaying border support panel #34516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
7 tasks
|
Size Change: -4 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Sep 3, 2021
There was a problem hiding this comment.
✅ Toggled off a single border support property for the pullquote block in lib/theme.json e.g. color
✅ Confirmed no border panel displayed under Pullquote in the Global Styles sidebar's "By Block Type" tab.
✅ Checked out this PR, refreshed and confirm that the border panel now displayed and still excluded the opted out of feature
✅ Toggled feature back on and confirmed panel still displayed
✅ Toggled all features off and confirmed panel no longer displayed
Good pick up. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes problem where if only some border support features were opted into the border panel would not display within the Global Styles sidebar.
How has this been tested?
lib/theme.jsone.g. colorTypes of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).