Components: fix selected value computation in CustomSelectControl when no initial value is set
#34490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Feature] Component System
ciampo
changed the title
CustomSelectControlCustomSelectControl when no initial value is set
|
Size Change: +9 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when opening the repo's Storybook, the
CustomSelectControlstory shows an error:The error seems to be caused by the fact that, when invoking the
useSelecthook (imported from downshift, we always pass theselectedValueproperty — even when a value is not passed explicitly. This seems to interfere with how theuseSelecthooks computes the overallselectedValue, which ultimately ends up in theselectedValuebeingundefined.This PR aims at fixing this issue by setting the
selectedValueoption only when the potential value for it is notundefinedornull.How has this been tested?
Storybook example works again locally
Screenshots
N/A
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).