Add default editor styles applied to themes without theme.json and without editor styles #34439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
ellatrix,
spacedmonkey and
TimothyBJacobs
as code owners
youknowriad
commented
Sep 1, 2021
|
|
||
| p { | ||
| line-height: 2; | ||
| } |
There was a problem hiding this comment.
@jasmussen this is the styles file if you want to tweak it.
There was a problem hiding this comment.
I've got a related PR at #34334 that enqueues the global styles for all themes. After it lands, shouldn't these styles live at lib/theme.json?
There was a problem hiding this comment.
I don't know, what I know is that they need to be in a dedicated setting in order for this logic to apply https://github.com/WordPress/gutenberg/pull/34439/files#diff-d00cfe048041886ee9b16f6f42422317b6e770cbea20cbe0e4d0ca7c8e0ec0e1R159-R161
There was a problem hiding this comment.
hey, so since #35424 all themes provide some styles to settings: at least they'll have the core preset styles. That inadvertently cause a bug for themes that don't provide any editor styles: they no longer had any defaults. See issue at #35730
I've created a fix for this at #35736 but I'm not convinced is the right approach. So I've prepared a second fix to absorb the defaults as part of the styles we send to the client in global-styles.php, see #35737
I'd love hearing your thoughts on which approach makes more sense to you.
|
Size Change: +153 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
|
This is excellent. I'll see what polish we need to push for this one, it might be good to start simple and take it from there. That said, I'm seeing these styles loaded regardless of settings in both my own block theme and in TT1 blocks:
I have "use theme styles" applied, still seeing these instead. |
|
@jasmussen it should be better now :) Thanks for catching that. |
|
Alright, I pushed some styles:
Since these styles are shown only if you explicitly choose to show them, and for very old themes, there's no reason not to make it nice and easy to read. What do you think? |
kjellr
approved these changes
Sep 1, 2021
There was a problem hiding this comment.
Left one minor comment. Aside from that, this feels really nice and simple. I tested in a few different themes, and it works when it's supposed to. 👍
It would be nice to bundle this into a WP point release so folks don't have to wait until 5.9 to experience it. The current experience feels like a regression to me, so I think there's some good reason to push it in early.
Co-authored-by: Kjell Reigstad <kjell.reigstad@automattic.com>
|
🔥 |
paaljoachim
added
the
Backport to WP Minor Release
|
I added the ""Backport to WP Minor Release" based on @kjellr 's comment:
|
This was referenced Oct 18, 2021
7 tasks
|
My original issue #31211, which was the 2nd generation of this issue specifically called out a line-height problem. The old default of I also noticed that the Gutenberg style problem made its way into the core. In the past, deactivating the plugin fixed it. Today, enabling the plugin fixes it. Much appreciated. I am going to close my issue. |
Mamaduka
removed
the
Backport to WP Minor Release
This was referenced Nov 27, 2023
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #34397
This PR adds some default editor styles for themes that don't style the editor at all:
They also apply to all themes when you uncheck "use theme styles" in the preferences.
Testing instructions
Check with a variety of themes: