-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore alternative documentation for BottomSheet Header component. #34339
Merged
enejb
merged 1 commit into
rnmobile/add/bottom-sheet-header
from
rnmobile/add/bottom-sheet-header-documentation
Aug 26, 2021
Merged
Explore alternative documentation for BottomSheet Header component. #34339
enejb
merged 1 commit into
rnmobile/add/bottom-sheet-header
from
rnmobile/add/bottom-sheet-header-documentation
Aug 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Leverage short, declarative statements when possible.
dcalhoun
force-pushed
the
rnmobile/add/bottom-sheet-header-documentation
branch
from
August 26, 2021 22:01
9f62347
to
5029037
Compare
I like the new documentation. |
enejb
approved these changes
Aug 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Merge away!
enejb
added a commit
that referenced
this pull request
Sep 7, 2021
* Add new Header bottomSheet component * Include the new Header component in buttomSheet * Update NavigationHeader to use the new Header component for backwards compatibility * Update all instances of NavigationHeader with Header * Update BottomSheet Header documentation to reduce its size (#34339) Leverage short, declarative statements when possible. * Move Header to NavBar * Update usage from Header to NavBar * Remove the NavigationHeader component * Fix space in the styles Co-authored-by: David Calhoun <438664+dcalhoun@users.noreply.github.com>
enejb
pushed a commit
that referenced
this pull request
Sep 7, 2021
Leverage short, declarative statements when possible.
This was referenced Nov 27, 2023
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Type] Developer Documentation
Documentation for developers
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to increase focus of documentation via:
How has this been tested?
Viewed rendering on GitHub.
Screenshots
n/a
Types of changes
Documentation
Checklist:
*.native.js
files for terms that need renaming or removal).