Global Styles: Fix block-level global styles color panels #34293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BackgroundColor and color are opt-out block supports: they're enabled if there's support for any color unless the block opts-out from them explicitly. Global styles UI panels were't respecting this opt out process, which is why we add logic to validate whether or not a block has turned off background color and color supports.
jeyip
added
[Type] Bug
|
Size Change: -589 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
This was referenced Aug 25, 2021
oandregal
reviewed
Aug 26, 2021
packages/edit-site/src/components/editor/global-styles-provider.js
Outdated
Show resolved
Hide resolved
|
@oandregal I added unit specs to verify the color support opt-out behavior in For now, I used a dummy test component to validate logic. I wanted to use actual Global Styles Color Panel components as children for the provider, but it would've been a big lift to figure things out. It's probably best tackled in a separate PR. |
oandregal
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Background color and text color are opt-out block supports. That is to say, they're enabled if there's a support key for any color unless the block opts-out from them explicitly. For example, the paragraph block only specifies support for link colors.
gutenberg/packages/block-library/src/paragraph/block.json
Lines 35 to 37 in ac41a59
The global styles paragraph color panel, however, still displays both text and background color supports. This behavior is desired and expected.
The issue is that global styles UI panels aren't respecting blocks explicitly opting out of text and background color supports. The cover block is a specific example.
gutenberg/packages/block-library/src/cover/block.json
Lines 73 to 77 in 599b60d
How has this been tested?
Screenshots
Before
After
Types of changes
Bug fix. Potentially addresses #34150
Checklist:
*.native.jsfiles for terms that need renaming or removal).