Add contextual help text to the Scale property in featured image block. #34158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtias
added
[Feature] Design Tools
|
Size Change: +111 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Aug 19, 2021
| 'Image is sized to maintain its aspect ratio and cropped to fill the entire space.' | ||
| ), | ||
| contain: __( | ||
| 'Image is scaled to fill the space without clipping the content.' |
There was a problem hiding this comment.
I wondered whether we should include that this setting maintains the aspect ratio. But the visual effect and the added context of the fill option feels sufficient.
talldan
reviewed
Aug 19, 2021
| /> | ||
| </> | ||
| ); | ||
|
|
||
| const scaleHelp = { | ||
| cover: __( | ||
| 'Image is sized to maintain its aspect ratio and cropped to fill the entire space.' |
There was a problem hiding this comment.
The mention of aspect ratio could be confusing as I'd consider that width/height of the natural image.
How about something like:
'Image is cropped and scaled to fill the entire space without being distorted'
mtias
force-pushed
the
add/featured-image-scale-help-text
branch
from
40f5e09 to
af6cee2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some clarity over these options. Help text is contextual to the current chosen option.
We have discussed before how these tools are a good place to inform and guide and not merely perform.