Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update incorrect Settings examples in "Global Settings & Styles" #34084

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Docs: update incorrect Settings examples in "Global Settings & Styles" #34084

merged 1 commit into from
Aug 16, 2021

Conversation

chthonic-ds
Copy link
Contributor

Description

The Settings examples provided for:

  • "Disable border radius for the button block"
  • "Provide the group block a different palette than the rest"

...are incorrect due to a "blocks" property name missing from the hierarchy.

This change adds the missing "blocks" property name for each example.

How has this been tested?

Screenshots

Types of changes

Documentation

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Aug 15, 2021
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @chthonic-ds! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@ntsekouras ntsekouras added the [Type] Developer Documentation Documentation for developers label Aug 16, 2021
Copy link
Member

@oandregal oandregal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@oandregal oandregal merged commit de41644 into WordPress:trunk Aug 16, 2021
@github-actions github-actions bot added this to the Gutenberg 11.4 milestone Aug 16, 2021
@chthonic-ds chthonic-ds deleted the patch-1 branch August 16, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants