Add information about selected element types for Group Block #33976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
the
[Block] Group
|
Size Change: +1.72 kB (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
jorgefilipecosta
approved these changes
Aug 31, 2021
ntsekouras
reviewed
Sep 2, 2021
There was a problem hiding this comment.
Thanks for working on this @getdave!
I was wondering if it makes more sense to extract this to a reusable component since it's already being used by Group, Query Loop and Template Part.. 🤔
getdave
force-pushed
the
add/information-about-group-block-html-element
branch
from
bc06936 to
ba3d6ed
Compare
ntsekouras
reviewed
Sep 10, 2021
There was a problem hiding this comment.
Thanks for iterating on this @getdave! I've left some comments but it's working well!
ntsekouras
approved these changes
Sep 10, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The group block allows you to select an HTML element to be used as it's TagName. However, there is no inline guidance for the purpose of these elements which could lead to the introduce of a11y issues.
This PR takes a first step of adding a notice which explains a little about the selected element.
Currently the info was gleaned from MDN docs, but I'm open to suggestions and improvements.
In future we could look to scan the document and provide more contextual advice (eg: "We've noticed you already have a
<main>element in your page" etc.) but for now let's keep things simple.Closes #31502
How has this been tested?
<div>default.Screenshots
Screen.Capture.on.2021-09-09.at.17-03-45.mov
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).