Fix the site editor breaking in firefox #33896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
Size Change: -10.8 kB (-1%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Yes, we don't have an error boundary in the site editor. Update: Created and issue #33899 and will follow up with PR shortly. |
Mamaduka
reviewed
Aug 5, 2021
| @@ -87,6 +87,10 @@ export default function useMultiSelection() { | |||
| * select the entire block contents. | |||
| */ | |||
| useEffect( () => { | |||
There was a problem hiding this comment.
Maybe we should use useRefEffect here instead of useEffect?
Both useSelectAll and useArrowNav are using useRefEffect hook.
gutenberg/packages/block-editor/src/components/writing-flow/index.js
Lines 35 to 37 in 9e2fc57
P.S. I haven't got a chance to use this hook in action yet, but this seems like a good use case.
There was a problem hiding this comment.
I updated to use useRefEffect and indeed, it seems to work.
3 tasks
creativecoder
approved these changes
Aug 6, 2021
There was a problem hiding this comment.
This fixes the Template and Site editor crashes for me, as well.
Though note another error is triggered (and more after that if you apply the same kind of fix).
Uncaught TypeError: can't access property "getAlignments", layoutType is undefined
useAvailableAlignments use-available-alignments.js:30
I think it makes sense to merge this now, though, to prevent the crash while we try to figure out a better solution.
|
@creativecoder I haven't been able to get the second error you shared, it might be theme specific. Consider opening an issue with more details. |
Thanks @youknowriad , I'm no longer able to replicate it testing on current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #33873
I'm not entirely certain that this is a good solution but in Firefox the ref is null initially meaning that it's probably not being attached on mount.
Guarding against the ref solves the issue but doesn't explain why the ref is empty in the first place.
Note: It seems we don't have an error boundary in the site editor or if we do, it's not working well.
Testing instructions