Evaluate WP commands with shell-like API in e2e tests #33720
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
kevin940726
force-pushed
the
try/rest-api-e2e-utils
branch
from
080271d to
f947052
Compare
kevin940726
force-pushed
the
try/wp-shell
branch
from
b9ba433 to
f70591b
Compare
|
I think we can use REST API to activate/deactivate plugins - https://make.wordpress.org/core/2020/07/16/new-and-modified-rest-api-endpoints-in-wordpress-5-5/ |
|
Do we have more places where eval could be useful? This PR addresses plugins activation/deactivation which could be a regular api endpoint (or two) so |
|
I agree with @adamziel. It would be nice to avoid Checked themes API, and it doesn't handle activation/deactivation, but we can extend it on our end. |
Oh somehow I missed it! Good to know that we actually support it. Yeah I agree |
7 tasks
kevin940726
force-pushed
the
try/rest-api-e2e-utils
branch
from
dea992c to
0734309
Compare
kevin940726
force-pushed
the
try/rest-api-e2e-utils
branch
from
0734309 to
07d770e
Compare
|
Closing in favor of #33414. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on #33414.
WIP
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).