Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Env: Add SSL port support to the docker compose #33480

Closed
wants to merge 2 commits into from
Closed

Env: Add SSL port support to the docker compose #33480

wants to merge 2 commits into from

Conversation

WraithKenny
Copy link

@WraithKenny WraithKenny commented Jul 15, 2021 •
edited
Loading

No description provided.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jul 15, 2021
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @WraithKenny! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@youknowriad youknowriad requested review from ntwb and gziolo July 16, 2021 10:26
@gziolo gziolo requested a review from noisysocks July 16, 2021 10:41
@gziolo gziolo added [Package] Env /packages/env [Type] New API New API to be used by plugin developers or package users. labels Jul 16, 2021
@gziolo gziolo changed the title add ssl port support to the docker compose Env: Add SSL port support to the docker compose Jul 20, 2021
@swissspidy
Copy link
Member

Any feedback? Should I try to automate the SSL Cert management, and automate mounting the required files, or is it enough for now to enable the ports?

How difficult would it be to integrate something like devcert?

@WraithKenny

This comment has been minimized.

Sign in to view
@WraithKenny WraithKenny deleted the add/ssl branch January 20, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahtallen noahtallen Awaiting requested review from noahtallen

@ntwb ntwb Awaiting requested review from ntwb

@gziolo gziolo Awaiting requested review from gziolo

@noisysocks noisysocks Awaiting requested review from noisysocks

Assignees
No one assigned
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Env /packages/env [Type] New API New API to be used by plugin developers or package users.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WraithKenny @swissspidy @gziolo @kenashworth