Packages: Hoist dependencies for WordPress packages #33387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
adamziel,
ajitbohra,
cameronvoell,
chrisvanpatten,
draganescu,
ellatrix,
getdave,
guarani,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
gziolo
added
[Type] Code Quality
gziolo
commented
Jul 13, 2021
|
Size Change: +1.14 kB (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
I wonder if it would be beneficial to add a GitHub Action workflow to check for when versions fall out of sync. Seems that there is an NPM package for this, but not sure if this would work for us. |
That's interesting. If I follow correctly it works a bit differently than what we need. As explained in their docs:
In our case, (if only possible) we try to use the same version of a given dependency in all packages to ensure that the issue isn't propagated to 3rd party consumers - including WordPress core. In general, keeping one version of the same library mitigates the risk of unexpected bugs when a library uses some internal state to cache values, store value changes in memory, etc. The issue mostly comes from how the |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
package-lock.jsonto ensure that all dependencies are hoisted for WordPress packages. It ensures thatnode_modulesfolders aren't installed insidepackages/subfolders. It isn't a strong requirement but a good practice that ensures that the same packages aren't installed several times when it isn't necessary.I noticed that
classnamesdependency had a different patch version declared in one of the packages so I updated all entries to the latest version2.3.1.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).