Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getTermsInfo() to workaround parsing issue for translatable strings #33341

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Update getTermsInfo() to workaround parsing issue for translatable strings #33341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions packages/block-library/src/query/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,8 @@ import { store as coreStore } from '@wordpress/core-data';
* @param {WPTerm[]} terms The terms to extract of helper object.
* @return {QueryTermsInfo} The object with the terms information.
*/
export const getTermsInfo = ( terms ) => ( {
terms,
...terms?.reduce(
export const getTermsInfo = ( terms ) => {
const mapping = terms?.reduce(
( accumulator, term ) => {
const { mapById, mapByName, names } = accumulator;
mapById[ term.id ] = term;
Expand All @@ -50,8 +49,13 @@ export const getTermsInfo = ( terms ) => ( {
return accumulator;
},
{ mapById: {}, mapByName: {}, names: [] }
),
} );
);

return {
terms,
...mapping,
};
};

/**
* Returns a helper object that contains:
Expand Down