Testing: Optimize e2e testing path navigation #3333
Conversation
aduth
added
the
[Type] Automated Testing
| @@ -1,13 +1,9 @@ | |||
| describe( 'Hello Gutenberg', () => { | |||
| before( () => { | |||
| cy.login(); | |||
| cy.newPost(); | |||
There was a problem hiding this comment.
I explicitly decided to avoid the newPost command in this test. Usually, when you have commands like those. You have one test performing this manually and an optimized version as a command to reuse across other tests. The reusable version can use any trick (fake APIs, direct URL access to speed up the behavior).
For this one specifically, I think it's fine to drop the manual testing, it's not that important but I just wanted to explain.
There was a problem hiding this comment.
You have one test performing this manually and an optimized version as a command to reuse across other tests.
Yeah, that made sense, with one of the ideas of this pull request being that if we can consolidate the optimization within newPost, visitAdmin (i.e. try navigating directly, handle login but only if encountered) then the individual tests benefit by having a consistent interface and not relying on any other tests to have handled specific steps.
|
|
||
| Cypress.Commands.add( 'visitAdmin', ( adminPath ) => { | ||
| cy.visit( '/wp-admin/' + adminPath ).location( 'pathname' ).then( ( path ) => { | ||
| if ( path === '/wp-login.php' ) { |
Related: #3069
This pull request seeks to improve e2e testing performance in two ways:
visitAdmincommand which automatically handles login behavior, preservingredirect_toof the desired screen to avoid navigating from the admin dashboard root after a login.Cypress.Cookies.defaultswhitelist, to avoid logins between testsTesting instructions:
Verify that e2e tests pass:
If you don't already have the local Docker environment set-up, first ensure Docker is installed, then run
./bin/setup-local-env.shFinally, run
npm run test-e2e