Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow themes to provide empty values for color.duotone and spacing.units #33280

Merged
merged 6 commits into from
Jul 8, 2021
Merged

Allow themes to provide empty values for color.duotone and spacing.units #33280

merged 6 commits into from
Jul 8, 2021

Commits on Jul 8, 2021

  1. Add tests for empty incoming presets

    @oandregal
    oandregal committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    22b3bd3 View commit details
    Browse the repository at this point in the history

  2. Add tests for null incoming presets

    @oandregal
    oandregal committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    456a7be View commit details
    Browse the repository at this point in the history

  3. Empty arrays are valid input data that need to be merged as well

    @oandregal
    oandregal committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    f62c32a View commit details
    Browse the repository at this point in the history

  4. Layout.units were not being considered for merging

    @oandregal
    oandregal committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    05fc7b2 View commit details
    Browse the repository at this point in the history

  5. Add tests for layout.units

    @oandregal
    oandregal committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    fd1fc57 View commit details
    Browse the repository at this point in the history

  6. Substitute layout.units per spacing.units

    @oandregal
    oandregal committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    2d19440 View commit details
    Browse the repository at this point in the history