Block editor: Iframe: Remove reset styles #33204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
Jul 5, 2021
| @@ -745,7 +745,8 @@ function gutenberg_extend_block_editor_styles_html() { | |||
|
|
|||
| ob_start(); | |||
|
|
|||
| wp_styles()->done = array(); | |||
| // We do not need reset styles for the iframed editor. | |||
| wp_styles()->done = array( 'wp-reset-editor-styles' ); | |||
There was a problem hiding this comment.
This is the easiest way to get the job done. We trick do_items in thinking that the handle has already been added, so it will be skipped.
ellatrix
commented
Jul 5, 2021
| // Don't try to add the reset styles, which were removed as a dependency | ||
| // from `edit-blocks` for the iframe since we don't need to reset admin | ||
| // styles. | ||
| if ( ownerNode.id === 'wp-reset-editor-styles-css' ) { |
There was a problem hiding this comment.
We need to ignore this in the compatibility layer because it will search stylesheet for relevant selectors, which also matches wp-reset-editor-styles.
|
Size Change: +15 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
|
Thanks for this. One of the biggest benefits of the iframe is that it blocks wp-admin styles from bleeding in. I can confirm this PR does that:
Compare to the block editor, which still has CSS bleed and shows the wp-admin link focus style here:
I'm happy to give this a green check as it works for me, but I'd love a sanity check by someone more familiar with the code. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes three stylesheets from the iframed editor:
wp-reset-editor-styles,commonandforms. These are not necessary since no admin styles need to be reset.commonalso seems to be adding focus styles that we don't want.Not sure if this is worth back porting.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).