Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for link color in WordPress 5.8 #33162

Merged
merged 3 commits into from
Jul 2, 2021

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Jul 2, 2021

Part of #20331

This documents the changes made to link color in WordPress 5.8, moving it from experimental to stable.

@oandregal oandregal self-assigned this Jul 2, 2021
@oandregal oandregal added the [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. label Jul 2, 2021

Using the Gutenberg plugin (version 8.3 or later), link color control is available to a number of blocks including Paragraph, Heading, Group, Columns, and Media & Text blocks. This is off by default, and requires the theme to opt in by declaring support:
Alternatively, opt-in via the old legacy support would also work:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has landed in WordPress 5.8. I wonder if we can remove it in WordPress 5.9 or should it live in core forever.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this in the past and the agreement seemed to be that experimental-link-color should only be part of the plugin and will be deprecated and removed when the plugin required WordPress 5.8 as the minimum version.

Going to prepare a PR to remove the above from core and make sure it's only part of the plugin.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oandregal oandregal mentioned this pull request Jul 2, 2021
82 tasks
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation changes look good to me 👍 I wonder if link color should be true by default given that other color controls are true. But I think we can change the default in a future version if we want to.

@oandregal oandregal merged commit e60de76 into trunk Jul 2, 2021
@oandregal oandregal deleted the update/link-color-docs branch July 2, 2021 15:07
@github-actions github-actions bot added this to the Gutenberg 11.1 milestone Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants