[Regression - Button]: Add deprecation for style.border.radius number
#33117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Regression
ntsekouras
requested review from
ockham,
Mamaduka,
oandregal,
jorgefilipecosta,
andrewserong and
aaronrobertshaw
7 tasks
|
Size Change: +224 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
7 tasks
|
Thanks for adding in this deprecation! I had a go at handling both kinds of border radius in #33100, but I think this approach using a deprecation is probably a better way to do it 🙂 |
aaronrobertshaw
approved these changes
Jul 1, 2021
There was a problem hiding this comment.
@ntsekouras Thanks for fixing this! 🙇
I could replicate the validation error using the example block code prior to applying this PR. After applying this the same block code is successfully migrated without error.
Digging into this deeper, it might help to highlight some other recent changes that may have impacted this. Support for both short and longhand CSS properties was recently added in #31641.
Part of that involved distinguishing between a shorthand and longhand value which was done via checking ! isString( value ). This doesn't take into account the deprecated numerical border radius value for a button block.
If that check was changed it would still cause a different set of block validation errors as it would apply border-radius: 0 where the old ad hoc radius application for buttons excluded that.
This PR's deprecation solves the problem neatly. It also updates the migration of the border support styles to maintain the other newer border support features such as color, style and width, which were added after the button's deprecations had been updated by the looks of it.
Nice work, and thanks again 👍
andrewserong
approved these changes
Jul 1, 2021
There was a problem hiding this comment.
Thanks for fixing this and adding the deprecation @ntsekouras! This change looks good to me, and I confirmed that the block pattern now renders correctly without throwing an error (and the block's attributes get migrated):
Also confirmed that button blocks with individual radii continue to be rendered as expected:
LGTM.
|
With all the tests passing and multiple approvals, I'll merge this one now. |
|
Cherry picked in |
|
Thanks for working on this, @ntsekouras. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: WordPress/pattern-directory#245
Regression from: #33017
The above PR(33017) added support for longhand border radius styles for each corner. This resulted in leaving the existing case of a button block with a number value at
border.style.colorunhandled from deprecations, therefore causing errors.It was discussed in
core-editorslack, after noticing that a core pattern was causing errors and made all tests fail, as they don't expectconsolemessages.While this PR fixes the regression, we need to handle in another PR the removal of the remote patterns from the tests, as we cannot let the repo's CI depend on something external.
Testing instructions
style.border.radiusas a number (that was the core pattern)Checklist:
*.native.jsfiles for terms that need renaming or removal).