Remove "is-dark-theme" rules from mixins. #33058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
Size Change: -1.07 kB (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
youknowriad
added
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 29, 2021
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://core.trac.wordpress.org/ticket/53525.
If you choose a dark background in a theme (you can customize twentytwentyone to have a black backgrond and white text), the block editor will detect the theme to be "dark", and apply an
is-dark-themeclass to the body.That class is meant only for block UI inside, such as white focus styles on dark backgrounds instead of dark blue focus styles. In this case it was also applied to form controls like text inputs, colorizing the placeholder. This was almost certainly just a copy/paste error, since we do need the placeholder colors customized for text inputs in the canvas:
The problem was this affected inputs elsewhere, like search:
☝️ Notice how there is white text that says "Search" in the inserter.
This PR fixes it:
Checklist:
*.native.jsfiles for terms that need renaming or removal).