[WIP] Button: Adopt width block support for button widths #32878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Status] In Progress
8 tasks
|
Size Change: +19 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
Closed
aaronrobertshaw
force-pushed
the
add/width-block-support
branch
from
5ab0a70
to
3406995
Compare
aaronrobertshaw
force-pushed
the
try/button-width-via-block-support
branch
from
c3dbfba
to
e0b9dde
Compare
aaronrobertshaw
force-pushed
the
add/width-block-support
branch
3 times, most recently
from
5c5e6e2
to
8ac6c73
Compare
aaronrobertshaw
force-pushed
the
try/button-width-via-block-support
branch
from
e0b9dde
to
f3efe0a
Compare
aaronrobertshaw
force-pushed
the
add/width-block-support
branch
2 times, most recently
from
d130ea7
to
83ad8a1
Compare
aaronrobertshaw
force-pushed
the
try/button-width-via-block-support
branch
from
f3efe0a
to
4941456
Compare
aaronrobertshaw
force-pushed
the
add/width-block-support
branch
from
83ad8a1
to
193263d
Compare
aaronrobertshaw
force-pushed
the
try/button-width-via-block-support
branch
from
4941456
to
c6363ae
Compare
aaronrobertshaw
force-pushed
the
add/width-block-support
branch
from
193263d
to
3e12547
Compare
aaronrobertshaw
force-pushed
the
try/button-width-via-block-support
branch
from
c6363ae
to
e2ed768
Compare
23 tasks
aaronrobertshaw
force-pushed
the
add/width-block-support
branch
from
3e12547
to
ce0236d
Compare
aaronrobertshaw
force-pushed
the
try/button-width-via-block-support
branch
from
e2ed768
to
6dbbcba
Compare
36 tasks
aaronrobertshaw
force-pushed
the
add/width-block-support
branch
from
ce0236d
to
1399bd8
Compare
aaronrobertshaw
force-pushed
the
try/button-width-via-block-support
branch
from
6dbbcba
to
c3a04dd
Compare
aaronrobertshaw
force-pushed
the
add/width-block-support
branch
from
1399bd8
to
4e0aedc
Compare
aaronrobertshaw
force-pushed
the
try/button-width-via-block-support
branch
from
c3a04dd
to
9a0f545
Compare
8 tasks
|
The width block support this PR relies on has been shelved for the foreseeable future. I'll close this PR as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 This is in progress and only intended to further discussion on the width block support and proposed width control. 🚧
Description
A proof of concept in switching the button block to use the proposed width block support.
Known issues
Custom widths that do not match preset percentage widths (
25,50,75,100) do not automatically take into account margin or column gap. Possible options include including<style>or styled component that does factor the margin/gap in.Next Steps
widthattribute to the block support'sstyle.dimensions.widthattributeHow has this been tested?
🚧 TBA.
Screenshots
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).