Add __experimentalFeatures default data for block-editor package
#32702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +551 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jun 16, 2021
| // These are the same as the core theme.json. | ||
| // Added them here as well as per this conversation | ||
| // https://github.com/WordPress/gutenberg/pull/32482#discussion_r648956243 | ||
| __experimentalFeatures: { |
There was a problem hiding this comment.
What happens when a user does:
<BlockEditorProvider settings={{ __experimentalFeatures: { color: { custom: false } } } } />
Does it merge with the defaults, should we do that?
annezazu
added
[Package] Block editor
|
I'm gardening my lingering PRs, and it's been a while since this one. Closing as it seems less pressing than other things I need to focus on. Can be reopened if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #32482 (comment)
Add a default value for
__experimentalFeatures, so the@wordpress/block-editoras a package doesn't require any other external data source to have default settings.How to test
global-styles.phpdisable hooking the filter to thegutenberg_experimental_global_styles_settings(comment lines 328 to 333)block-editorstore has defauls forsettings.__experimentalFeatures.