Fix in-between inserter not showing for wrapping horizontal block lists #32615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
commented
Jun 11, 2021
| } ); | ||
|
|
||
| if ( ! element ) { | ||
| if ( isBlockInsertionPointVisible() ) { |
There was a problem hiding this comment.
Not sure if this change is right, I wasn't fully able to understand the original code.
I wasn't sure why this early return didn't hide the insertion point in trunk.
There was a problem hiding this comment.
We should probably be adding it to all early returns below.
|
Size Change: -44 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
Nice to consolidate, drag and drop and the in-between inserter are indeed very similar, both are coordinate to insertion index. I wonder if we could reuse even more code? Would be cool to have a function where you can put in coordinates and get a root client ID and index. :) |
ellatrix
reviewed
Jun 11, 2021
packages/block-editor/src/components/block-list/use-in-between-inserter.js
Show resolved
Hide resolved
ellatrix
reviewed
Jun 11, 2021
packages/block-editor/src/components/block-list/use-in-between-inserter.js
Show resolved
Hide resolved
|
Looks like there's a few e2e tests failing related to the insertion point. |
glendaviesnz
force-pushed
the
fix/in-between-inserter-in-wrapping-horizontal-lists
branch
from
65151f3
to
cf38d68
Compare
glendaviesnz
force-pushed
the
fix/in-between-inserter-in-wrapping-horizontal-lists
branch
from
cf38d68
to
9012f6f
Compare
|
@talldan the fix for the e2e test is strange. For some reason in the e2e test run the inserter mouseover is more sensitive than in a local dev site, ie. the activation zone is much narrower. The console logs below are the mouse x and y In e2e test run instance: In the dev site the inserter appears to behave exactly the same as before this change, and I can't work out why it is different in the e2e chrome instance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue mentioned here - #32589 (review)
Uses the same edge detection system as drag and drop to determine in which position to show the in-between inserter.
Performance might be a little worse, but hopefully not too much of an impact.
How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).