Card: refactor subcomponents folder structure #32557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Package] Components
ciampo
requested review from
youknowriad,
gziolo,
diegohaz,
tyxla and
sarayourfriend
11 tasks
|
Size Change: -2 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
This was referenced Jun 9, 2021
Merged
tyxla
requested changes
Jun 10, 2021
…port all card components
ciampo
force-pushed
the
feat/components-card-refactor-folder-structure
branch
from
a8f786a to
564c683
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first of a series of PRs with the final goal of achieving the same result as #32243 in smaller (and easier to review) steps.
In this PR the folder structure of
<Card />and its subcomponents is changed so that each subcomponent has a dedicated folder. All of the subcomponents are then exported in theindex.jsfile. There shouldn't be any changes to the actual implementation.This PR will enable the next PRs to focus on swapping the current implementation with the new one (g2), without the noise caused by the folder structure changes.
Testing instructions
There are no changes to runtime code.
Components / Cardstories against the production version — there shouldn't be any differenceScreenshots
N/A
Types of changes
Refactor (folder structure)
Checklist:
*.native.jsfiles for terms that need renaming or removal).