Try: Alternate spacer min-height fix. #32543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Block] Spacer
|
Size Change: +1.39 kB (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
gwwar
approved these changes
Jun 9, 2021
|
Excellent point! I'll add a minwidth there! The original solution was not horizontally aware. Thanks Kerry. |
|
I pushed a fix so that it works in horizontal contexts:
It's "clever" in that it has a both 100% width and height now, with min-width/height fallbacks. But those 100 width/heights only actually span the block in context of their orientation, so it works without the need for further specificity. |
|
Going to land this one as an improvement over what we have, and will as always follow up on anything that might come. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #25528, I added a small overlay on the Spacer block giving it a min-height so that it's selectable even if it's only 1px tall. This was built in context of every single block in the editing canvas having a top and bottom margin, always.
Block themes do not have this margin anymore, relying instead only on margins that the theme provides. In that context, this extra tap-overlay is now conflicting with selecting blocks, shown here in red:
This PR does two things:
How has this been tested?
Checklist:
*.native.jsfiles for terms that need renaming or removal).