[Block Library]Rename QueryLoop to PostTemplate and change Query label #32514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Package] Block library
ntsekouras
requested review from
mcsf,
youknowriad,
mtias,
aristath,
gziolo,
jameskoster and
a team
ntsekouras
requested review from
ajitbohra,
nerrad,
ntwb,
spacedmonkey and
TimothyBJacobs
as code owners
This was referenced Jun 8, 2021
|
Regarding @jameskoster comment here: #32283 (comment)
I've no strong opinions here... --cc @mtias |
ntsekouras
force-pushed
the
rename/query-loop-and-query-labels
branch
from
070cb2b
to
fe59e9f
Compare
youknowriad
approved these changes
Jun 8, 2021
There was a problem hiding this comment.
This is looking good to me. Let's try to get this quickly to backport it. Any final thoughts/objections @jameskoster @mtias
|
Size Change: -741 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
|
Looks good — I'll tweak the description separately. |
mtias
approved these changes
Jun 8, 2021
mtias
reviewed
Jun 8, 2021
|
per discussion in DM with Nik, it seems we need the block fallback in the server as well. |
If it serves as inspiration, Social Icons also needed fallbacks on the server when we consolidated them with block variations: #20098. |
ntsekouras
commented
Jun 8, 2021
mcsf
reviewed
Jun 8, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jun 8, 2021
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 8, 2021
youknowriad
reviewed
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of: #30910
This PR renames
QueryLooptoPostTemplateand changesQueryblock's label toQuery Loop.Notes
QueryLoopblocks are handled in the parser level by renaming them toPost Templateblocks, so they will be still functional.Please test carefully and if you have some time it would be great to check about any missing strings that might be used for example in css class names or such details. I think I've covered it all but lots of moving parts with renaming.
Testing instructions
Queryblock in a page/FSE and make changes in editor and view front-end as well.Testing previous Query with QueryLoop
Query and QueryLoop.If you edit the page/post the
parserwill update theQueryLoopblock and will be saved as the renamed block onsave.