Memoize core-data selectors #32106
Closed
Memoize core-data selectors #32106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Performance
youknowriad
reviewed
May 21, 2021
youknowriad
added
the
Backport to WP 6.7 Beta/RC
|
Now I'm curious if our performance tests did catch the regression or not. |
|
Size Change: +30 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
It was the time GitHub actions were not behaving correctly the test failed because of not founding a selector unrelated to the changes " No node found for selector: tr[data-slug="gutenberg-test-plugin-disables-the-css-animations"] .activate a". Edited: After looking deeper The PR that caused the regression was not the template title edit and delete implementation #31678, but a follow-up bugfix #32035 and the performance tests passed on that PR that caused the regression. |
|
@jorgefilipecosta No blame on you here, we need some (additional) better tests :) |
ellatrix
force-pushed
the
fix/template-performance
branch
from
77c6b14
to
20ac1f5
Compare
|
So after a long search, we found that the performance issue only affects block based themes (TT1 Blocks). |
ellatrix
changed the title
ellatrix
changed the title
ellatrix
force-pushed
the
fix/template-performance
branch
from
20d5bb6
to
05808be
Compare
youknowriad
reviewed
May 24, 2021
ellatrix
force-pushed
the
fix/template-performance
branch
from
25b25a7
to
373677b
Compare
ellatrix
commented
May 24, 2021
ellatrix
force-pushed
the
fix/template-performance
branch
from
05006a1
to
6f0a317
Compare
ellatrix
force-pushed
the
fix/template-performance
branch
from
050484b
to
2e0af2f
Compare
ellatrix
removed
the
Backport to WP 6.7 Beta/RC
|
Can no longer reproduce the performance hit, perhaps something with the templates has now changed. |
|
I've been debugging the performance tests as well and this PR is still good to land (especially the selectors change). It's true that the performance impact is not very visible but it's there. A lot of components don't rerender anymore with this PR. |
ellatrix
force-pushed
the
fix/template-performance
branch
from
7a3579e
to
07555e9
Compare
ellatrix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the whole editor re-renders on every keystroke become a new reference is returned for the template entity record (which is also retrieved in the normal post editor).
I'm not sure IF we need to get the edited template record. If not, it's a pretty easy fix. If we do, we'll need to fix the
getEditedEntityRecordcached selector, because it currently invalidates on any entity change.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).