Adapt Gutenberg code to work after global styles lands in core #32059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
changed the title
oandregal
added
the
Global Styles
|
So far, this PR only deals with renaming things. It works with WordPress/wordpress-develop#1262 although it's not the final shape things should be. Would it be helpful to land this as it is so the next changes are isolated and easier to read? |
|
Size Change: 0 B Total Size: 1.86 MB ℹ️ View Unchanged
|
oandregal
force-pushed
the
core/add/global-settings
branch
from
3a2107c to
b239dd6
Compare
oandregal
commented
May 21, 2021
oandregal
commented
May 21, 2021
| } | ||
|
|
||
| add_action( 'init', 'gutenberg_experimental_global_styles_register_user_cpt' ); |
There was a problem hiding this comment.
These have been moved below for clarity.
oandregal
commented
May 21, 2021
oandregal
force-pushed
the
core/add/global-settings
branch
from
76a75fd to
e5874d6
Compare
ntsekouras
reviewed
May 24, 2021
ntsekouras
force-pushed
the
core/add/global-settings
branch
from
5a890b3 to
ac5de88
Compare
youknowriad
approved these changes
May 24, 2021
|
After some testing I encountered this behavior where the This is happening only if you install/activate the tt1-blocks theme from theme repository and it's not if you add the So to reproduce:
|
|
Nice catch @ntsekouras This is something that we need to be updated in WordPress core, this is the PR WordPress/wordpress-develop#1289 This is what happened:
I didn't run into this because I tested before 3 and you tested after. |
|
This PR is ready but I still see that there's a performance e2e tests failure. Sharing in case it rings any bell as to how fix it: |
oandregal
force-pushed
the
core/add/global-settings
branch
from
ac5de88 to
c8d8f22
Compare
|
I managed to run the test locally using the latest wp-env ( |
|
I'm not sure what's happening for the performance test but it feels to me that having that one failing on trunk is better than having all the e2e tests failing, so I'm merging. |
It's normal, because the test compares to trunk, which was broken. |
Merged
2 tasks
noisysocks
pushed a commit
that referenced
this pull request
May 25, 2021
Co-authored-by: ntsekouras <ntsekouras@outlook.com>
noisysocks
added
the
Backport to WP 6.7 Beta/RC
|
Adding this to |
gziolo
pushed a commit
that referenced
this pull request
May 25, 2021
Co-authored-by: ntsekouras <ntsekouras@outlook.com>
|
Cherry-picked to the Gutenberg 10.7 release. |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion for WordPress/wordpress-develop#1262
Adapts Gutenberg code to work once we shipped "global styles" to WordPress core.
Testing scenarios
__experimentalFeaturesdata for the block editor wordpress-develop#1262Instructions: