compose: Add types to useDebounce
#32015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +16 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
ciampo
reviewed
May 20, 2021
|
Love the work done in this PR to preserve the signature of the debounced function!
I also believe that our docs should be more detailed. We now have two choices:
|
I strongly prefer this option as it also improves the inline auto-complete based documentation, not just the README docs. I'll go ahead and make this change. |
sarayourfriend
force-pushed
the
add/types-compose-use-debounce
branch
from
9f54836
to
21ebe47
Compare
ciampo
reviewed
May 20, 2021
fullofcaffeine
added a commit
that referenced
this pull request
May 22, 2021
…-take-2 * trunk: (57 commits) Image block: fix cover transform and excessive re-rendering (#32102) compose: Add types to useMergeRefs (#31939) Navigation: Fix collapsing regression. (#32081) components: Promote Elevation (#31614) compose: Add types to useReducedMotion and useMediaQuery (#31941) Update the graphic that appears in the Template Editor welcome guide (#32055) Block Navigation: use CSS for indentation with known max indent instead of spacer divs (#32063) Fix broken template part converter modal styles. (#32097) compose: Add types to `usePrevious` (#31944) components: Add ZStack (#31613) components: Fix Shortcut polymorphism (#31555) compose: Add types to `useFocusReturn` (#31949) compose: Add types to `useDebounce` (#32015) List View: Simplify the BlockNavigation component (#31290) Remove query context leftovers (#32093) Remove filter_var from blocks (#32046) Templates: Remove now-obsolete gutenberg_get_template_paths() (#32066) [RNMobile] Enable reusable block only in WP.com sites (#31744) Rename ViewOwnProps to PolymorphicComponentProps (#32053) Rich text: remove inline display warning (#32013) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add types to
useDebounce. No runtime changes.One question I have is that this basically replicates the "we don't care about these arguments" approach from before but it makes the documentation pretty bad. So the alternative is to explicitly document each of the parameters to
debounce. It's highly unlikely that the parameters todebounceare going to change so I think it's safe to do so. What do y'all think? I think it would be a big improvement over what we have now.Part of #18838
How has this been tested?
Type checks pass.
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).