Remove figure margins consistently in image blocks. #31650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
Size Change: +22 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
I had a concern about zeroing in the left/right margins on an adjacent PR, but that was not a problem in the themes I tested, and is not a problem here — the wide system auto left/right margins override as they should, seen here in TT1:
At a glance things also look fine in Empty Theme, however for some reason, probably trunk related, I don't have access to left/center/right controls for images here:
|
This is related to #30568. It's undecided now :) we can allow left/right there but these will show left/right aligned by the edge of the container and not the "centered" content area. |
|
Gotcha. In any case, this seems okay. Should those margins apply only to left and right, though? I guess that's a larger question around general block margins. I'm leaning towards yes to zero out the margins, and happy to green check that. But I'd also be happy to hear from some of the themers CC'ed, as I've seen many "block margin" CSS variables in themes lately. |
they already apply to the other alignments, this PR adds them to left/right/center as these alignments change the markup of the block itself. |
jasmussen
approved these changes
May 10, 2021
youknowriad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #29517
in #29517 we removed the figure margins from all blocks but in the image block, when it's left, right or center aligned the figure is actually not the block wrapper, too the rule there don't apply. This PR adds an additional style to fix that.
Testing instructions