Site Logo: Rename sitelogo to site_logo #31511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
Size Change: -3 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
jeyip
reviewed
May 5, 2021
There was a problem hiding this comment.
Testing
Requirements
- Can use an existing image from the media library
- Can upload a new image
- Site logo displays in frontend
- Site logo displays in site editor
- Site logo displays in post editor
- Site logo is persisted across various pages
Browsers
- Edge
- Firefox
- Safari
- Chrome
Note: Unrelated to this PR, but the layout of the site logo on the frontend doesn't match the site editor for the tt1-blocks theme. This issue already exists in the Gutenberg trunk. Did you see anything similar for other themes you tested @creativecoder? I can make a Github issue for the themes team.
| Site Editor | Frontend |
|---|---|
 |
 |
jeyip
approved these changes
May 5, 2021
creativecoder
requested review from
ntsekouras,
mtias,
youknowriad,
scruffian and
jasmussen
|
I've pinged some folks who have made commits to this block for additional reviews. |
|
No strong opinions here. |
|
Any concerns here about breaking the Site Logo block for existing Gutenberg plugin users when this option change is released? I can follow up to this PR and add a check for the |
|
I'm not too concerned personally as it was an experimental block but let's make sure to include this change in 10.6 to avoid breaking it later (since 10.6 stabilizes the block) cc @vdwijngaert |
vdwijngaert
pushed a commit
that referenced
this pull request
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the Site Logo block is being considered for the WP 5.8 release, it seems prudent to make sure the settings match existing naming conventions and data types. This change does 2 things
sitelogotosite_logo.stringtointeger, since this is an attachment id, which are typically represented by integers in the API response.How has this been tested?
Screenshots
No user facing changes
Types of changes
Breaking change (fix or feature that would cause existing functionality to not work as expected), since it changes an option name
Checklist:
*.native.jsfiles for terms that need renaming or removal).