Table: Add border block support #31265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the same pattern as the utilities added for the colors block support. Its intended use is in retrieving border related styles and classes to apply to inner block elements.
This extends the table block to opt into border color, style and width block support features. It skips serialization of this support so it can be applied to the inner `table` element.
aaronrobertshaw
added
[Type] Enhancement
This was referenced Apr 28, 2021
|
Size Change: +328 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
In testing I'm only seeing the outer borders receive the styles in TT1 blocks, but I'm unsure if that's a theme issue: Even with that issue, this is a really good addition to the block, so lets continue and follow-ups can address any problems. |
Thanks for testing @talldan! I came across that issue yesterday when I had to switch to another branch, then back to this one. I had to restart the Gutenberg watch task to rebuild it. After that the new styles were picked up correctly. I was able to replicate this just now. Checking out the PR branch the new styles didn't build correctly. Rebuilding Gutenberg then reloading the editor sorted it out for me. That said, there could be a few quirks across themes. I tested in half a dozen of the usual suspects and the borders displayed ok.
In TT1, if not specifying the border style but setting the width and color, the I'd like to have used CSS variables but with the table being a static block they'd have to have been saved in the content which leads to issues with kses in different environments. Open to suggestions on a good approach to solve this. |
This was referenced Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #31261
Follow up to #30791
Depends on #31264
Description
Adds block support for border color, style and width to the Table block.
How has this been tested?
Manually.
core/tablecontext.Screenshots
Types of changes
New feature.
Checklist:
*.native.jsfiles for terms that need renaming or removal).