Fix nav editor links to correctly persist new tab target attribute #30956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +166 B (0%) Total Size: 1.46 MB
ℹ️ View Unchanged
|
getdave
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
|
There may be a wider follow-up to this required where we methodically go through all the possible nav menu item fields and ensure they are correctly mapped to block attributes (and the inverse!). We'll need some unit tests for this to avoid future regressions. |
Yes, With Gutenberg plugin disabled > wp-admin/nav-menus.php > Screen Options (then select Link Target)
|
gwwar
approved these changes
Apr 21, 2021
There was a problem hiding this comment.
Thanks @getdave this manually tests well for me and code looks reasonable . I'm not as familiar with the serialization here, so a +1 from other folks working on the navigation editor wouldn't hurt.
I tested this against the old menu editor, navigation editor, and populating a navigation block from a menu.
menu.mp4
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #30323.
Currently within the Navigation Editor the feature to cause a nav link to "Open in new tab" does not work.
Whilst it is possible to toggle the control and have the state persist within the editor, if you reload the editor the setting state is not persisted (ie: it is always "off").
The reason for this is that that the
settingsproperty on the underlying<LinkControl>component is calledopensInNewTabwhereas the menuItem data (when stored in the database) expects atargetproperty with a string value of_blank. This mismatch has not been accounted for when translatingcore/navigation-linkblocks into the equivalent menu item to be persisted into the database.This PR updates things so that
targetattribute to_blankif the block hasopensInNewTabset totrue.opensInNewTabproperty is set based on the presence of the string_blankas the value of the menu item'stargetproperty.🙏 Note: I'd appreciate a confidence check that the value
_blankis the correct string value as used on the old WordPress menu page.How has this been tested?
Manual Testing
In the Navigation Editor (experimental):
Opens in new tabto "on".Opens in new tabsetting is still set to "on".Opens in new tabsetting to "off".Opens in new tabsetting is still set to "off".Note is is important to check that you can toggle this setting on and off. Also repeat for multiple nav items within a menu and using different link types.
Automated Tests
Run
npm run test-unit packages/edit-navigation/src/store/test/. See all ✅ .Screenshots
Screen.Capture.on.2021-04-19.at.11-47-26.mov
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).